search

lpsinger / ligo.skymap

Localization of gravitational-wave transients. Mirror of https://git.ligo.org/lscsoft/ligo.skymap
23 stars 18 forks source link

start enforcing that the python version is >= 3.9 #22

Closed ahnitz closed 1 year ago

ahnitz commented 1 year ago

The latest release of ligo.skymap revealed a mistake in packaging. I believe it was intended that the latest release be restricted to python3.9 or later and that support be dropped for python3.8.

There is a typo in the setup.cfg file so that the restriction is not actually enforced. This means that attempting to install ligo.skymap from earlier python versions with e.g. pip will download the latest and then fail to build rather than downloading an older compatible version as desired.

This change request, updates the cfg file to require python3.9 or later.

https://packaging.python.org/en/latest/guides/dropping-older-python-versions/

@lpsinger If you are happy to merge this, I might request to aid downstream packages to release a minor update and take down the source version of the last release. Otherwise, that version will continue to cause problems in older python versions. This is pretty straightforward to do on pypi itself.

lpsinger commented 1 year ago

Thanks for spotting that. It's been broken for a while. It's now fixed on PyPI: https://pypi.org/project/ligo.skymap/