adding center parameters for AllSkyAxes

lpsinger / ligo.skymap

Localization of gravitational-wave transients. Mirror of https://git.ligo.org/lscsoft/ligo.skymap

22 stars 18 forks source link

adding center parameters for AllSkyAxes #26

Closed swyatt7 closed 9 months ago

swyatt7 commented 9 months ago

Adds the ability to center a mollweide or aitoff projection on given coordinates.

The center parameter follows the same behavior as the zoom and globe projections. It is defaulted to "180d 0d" upon init in the AllSkyAxes class, and cast into an astropy.coordinates.SkyCoord, where the ra and dec are set to the header "CRVAL1" and "CRVAL2", respectively.

swyatt7 commented 9 months ago

Added tests in test_plot.py
Added comparison images in tests/baseline for the centering in mollweide and aitoff projections
Also a line that surpresses an astropy.wcs warning with plots with obstime.

lpsinger commented 9 months ago

Also, please add a change log entry!

lpsinger commented 9 months ago

This looks great! This is a GitHub mirror of https://git.ligo.org/lscsoft/ligo.skymap/ and the real CI/CD pipeline runs in GitLab, so I pushed this to a branch and opened it as a GitLab MR here: https://git.ligo.org/lscsoft/ligo.skymap/-/merge_requests/343

lpsinger commented 9 months ago

Merged as https://git.ligo.org/lscsoft/ligo.skymap/-/merge_requests/343. Thanks! Do you need this in a release?

swyatt7 commented 9 months ago

Awesome! Thanks for putting up with excellent linting skills :) . And I don't need it immediately, you can just include it in the next release. I'm writing some plotting functions for the gwtm_api , and I can just test them with my current ligo.skymap environment I developed in.