lpsmith / postgresql-simple

Mid-level client library for accessing PostgreSQL from Haskell
Other
206 stars 71 forks source link

Escape double '??' to a literal '?' #248

Closed Vlix closed 5 years ago

Vlix commented 6 years ago

This change makes it possible to use literal question marks in queries to PostgreSQL. This is needed to be able to use the new JSON operators. https://www.postgresql.org/docs/9.5/static/functions-json.html

This change can't break anything, since:

Vlix commented 6 years ago

Anyone know how often @lpsmith checks this repository?

Vlix commented 6 years ago

The tests here use PSQL version 9.4 since that's when jsonb and the question mark operators got introduced. If it's needed to keep testing postgresql-simple on version 9.3, I can make changes so the tests are only run on a seperate test that uses a PSQL version higher than 9.3

Vlix commented 5 years ago

Bump.

Doesn't anyone want to use JSON operators in PostgreSQL?

phadej commented 5 years ago

@Vlix sorry for not noticing, I haven't watched this repository closely. If you mind making PR against my fork, it would help (there's up to date travis setup as well)

Vlix commented 5 years ago

@phadej Ah, hadn't noticed the maintainer has switched. Will do.