search

lptstr / winfetch

🛠 A command-line system information utility written in PowerShell. Like Neofetch, but for Windows.
MIT License
1.4k stars 77 forks source link

Terminal info is incorrect when installed with scoop and run under wezterm terminal and git bash shell #206

Closed ykhan21 closed 9 months ago

ykhan21 commented 9 months ago

When installed with scoop and run under the wezterm terminal and the git bash shell, winfetch displays the terminal name as "sh" instead of "wezterm-gui". This occurs when running winfetch normally, by entering "winfetch" in the shell. However, when running winfetch in the same environment but as: pwsh -noprofile -file ~/scoop/apps/winfetch/current/winfetch.ps1, then the terminal is displayed correctly, as "wezterm-gui".

rashil2000 commented 9 months ago

Oh, I somehow missed adding sh to this array.

https://github.com/lptstr/winfetch/blob/8cf5f860d55ef1f7f4fcdc45a07a49544d065236/winfetch.ps1#L657

Would you like to fix this?

ykhan21 commented 9 months ago

I don't mind, you can add it. Though shouldn't the shell be bash? When I use Wezterm with the bash shell that comes with git for windows, echo $SHELL outputs /usr/bin/bash.

rashil2000 commented 9 months ago

Bash is already present in the array.

I've made the change: https://github.com/lptstr/winfetch/commit/8d4f687b5e212f276c63ff26f09bee218b65d9b6