search

lquerel / gcp-bigquery-client

GCP BigQuery Client (Rust)
Apache License 2.0
97 stars 64 forks source link

Add `query_all`, a paginated query method #22

Closed LiHRaM closed 2 years ago

LiHRaM commented 2 years ago

Hi,

We run queries that exceed the 10 MB response limit. After some work digging through the API, we figured out how to do the pagination, but wanted to contribute back to the project by adding a method to the JobApi that paginates by default.

It's not a complete solution by any means, but it works for us and we're happy to modify it to match the vision of this project.

lquerel commented 2 years ago

Thanks for this contribution. I added a small comment. Please let me know once you have PR ready (comments + test).

LiHRaM commented 2 years ago

@lquerel Thanks! I'm afraid I can't see the comment anywhere, could it be that it's not been submitted yet?

lquerel commented 2 years ago

@lquerel Thanks! I'm afraid I can't see the comment anywhere, could it be that it's not been submitted yet?

My bad, I forgot to submit the review...

LiHRaM commented 2 years ago

@lquerel Please have a look when you have time. It should be ready now. Thanks!

lquerel commented 2 years ago

LGTM.

Thanks for this contribution. I will submit a new version this weekend.

lquerel commented 2 years ago

Version 0.12.2 published. Thanks again.