Let `Client::from_service_account_key_file` return `Result<Client, BQError>`

lquerel / gcp-bigquery-client

GCP BigQuery Client (Rust)

Apache License 2.0

92 stars 60 forks source link

Let `Client::from_service_account_key_file` return `Result<Client, BQError>` #39

Closed burmecia closed 1 year ago

burmecia commented 1 year ago

The function Client::from_service_account_key_file is easy to fail by common errors, such as wrong file path, invalid key file, have no permission and etc. Any particular reason why it doesn't return Result<Client, BQError> like Client::from_service_account_key?

lquerel commented 1 year ago

Definitely something that should be improved. Contributions are welcome.