search

lquerel / gcp-bigquery-client

GCP BigQuery Client (Rust)
Apache License 2.0
92 stars 60 forks source link

The tabledata.list API method return type might be wrong? #66

Closed enricozb closed 6 months ago

enricozb commented 9 months ago

The TableDataApi::list method (source here):

    pub async fn list(
        &self,
        project_id: &str,
        dataset_id: &str,
        table_id: &str,
        parameters: ListQueryParameters,
    ) -> Result<TableDataInsertAllResponse, BQError> {

returns a TableDataInsertAllResponse. Shouldn't this return the rows?

lquerel commented 8 months ago

You are correct, this method should not return a TableDataInsertAllResponse. I don't know for certain if I will be able to fix that soon since my to-do list for other projects is already extensive. If you have the bandwidth, please don't hesitate to submit a PR with the corresponding fix, and I will review it. Thanks.

enricozb commented 8 months ago

Here you go, this is what i was using locally: https://github.com/lquerel/gcp-bigquery-client/pull/67/files