search

lquerel / gcp-bigquery-client

GCP BigQuery Client (Rust)
Apache License 2.0
92 stars 60 forks source link

Update yup-oauth2 requirement from 8.3 to 9.0 #84

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
DoumanAsh commented 2 months ago

@lquerel Can you merge it and release new version? Currently you cannot compile this crate due to yup-oauth2 yanking 8.4

lquerel commented 2 months ago

IIRC there are multiple adaptations to do to support yup-oauth2 v9. I don't exactly know when I will be able to make these changes. Please feel free to propose a PR.

serprex commented 2 months ago

IIRC there are multiple adaptations to do to support yup-oauth2 v9. I don't exactly know when I will be able to make these changes. Please feel free to propose a PR.

I don't think so, looking at their repo they pushed v9 out as v8.3.3 with different version number to address the hyper-rustls update being semver breaking

https://github.com/dermesser/yup-oauth2/pull/213

dependabot[bot] commented 2 months ago

Looks like yup-oauth2 is up-to-date now, so this is no longer needed.