search

lquerel / gcp-bigquery-client

GCP BigQuery Client (Rust)
Apache License 2.0
94 stars 62 forks source link

install protoc in gh actions #98

Open imor opened 2 weeks ago

imor commented 2 weeks ago

This PR installs the protoc compiler before running tests and clippy to avoid their failure since we now depend on it to compile the Storage Write API support.

imor commented 2 weeks ago

@lquerel Tests are now failing due to invalid service account key. Can you please take a look. Is the secret GOOGLE_APPLICATION_CREDENTIALS up to date?

serprex commented 2 weeks ago

bit of an aside, can this feature be a feature in Cargo.toml?

lquerel commented 2 weeks ago

The other option is to "vendor" the code generated by protoc in order to remove the dependency on it, as @imor initially did. However, I still support the removal of the git submodule, which I'm not a fan of.

lquerel commented 2 weeks ago

The more I think about this latest release, the more I believe it would be simpler to eliminate this dependency on protoc through vendoring, as @imor initially did. I think I will go in this direction without reintroducing the git submodule.

I hope to implement this by the end of the week if my professional schedule allows. If it's an urgent need, feel free to submit a PR in this direction (@serprex , @imor).

imor commented 2 weeks ago

@lquerel It's not urgent for me. I'm ok to wait until the weekend. Thanks.