make storage api a feature

lquerel / gcp-bigquery-client

GCP BigQuery Client (Rust)

Apache License 2.0

97 stars 64 forks source link

make storage api a feature #99

Closed serprex closed 1 month ago

lquerel commented 3 months ago

Why link the BigQuery Storage Write API to this possibility of using GZIP for the insert_all method, which does not rely on the gRPC API?

serprex commented 2 months ago

I've misunderstood these changes

changed to storage feature, not sure if you want it as a default feature

lquerel commented 1 month ago

I don't think we need this anymore because I changed the way Tonic/Prost is integrated. The generated code is now vendored into the repo to avoid code generation at each build. I'm closing this PR, but feel free to reopen it if you have a strong argument for integrating this feature flag. Thanks!