search

lquixada / cross-fetch

Universal WHATWG Fetch API for Node, Browsers and React Native.
MIT License
1.67k stars 104 forks source link

node-fetch v3 is out #115

Closed etodanik closed 2 years ago

etodanik commented 2 years ago

Is it time to update?

p-j commented 2 years ago

Please don't

Fetch implementations that run on Node shouldn't force ESM on end users/developpers.

Using ESM in Typescript or older projects is not easy and will break things. It's just not worth it at this time.

As a side note: fetch is coming to node so there is really no hurry in breaking everything...

lquixada commented 2 years ago

@israelidanny as pointed out by @p-j , v3 has just been released and node-fetch is facing a lot of issues for being an ESM only lib (see link provided by him). I feel it would be prudent to monitor how that discussion unfolds before taking any actions.

@p-j re: your side note, unfortunately we can't firmly state that fetch is coming to node. Although the API has been merged intoundici, it's still unclear if undici itself will ever be merged into the node core. See discussion here: https://github.com/nodejs/node/issues/38533.

Lioness100 commented 2 years ago

Even if undici isnt't merged into node core, will we eventually replace node-fetch with it?

lquixada commented 2 years ago

@Lioness100 so far I don't see a good reason to replace node-fetch. We can keep a close eye on how undici develops though.