search

lquixada / cross-fetch

Universal WHATWG Fetch API for Node, Browsers and React Native.
MIT License
1.67k stars 104 forks source link

move npm-run-all to devDependencies #31

Closed gr2m closed 5 years ago

gr2m commented 5 years ago

follow up for https://github.com/lquixada/cross-fetch/commit/9af3c4447192933f00ee52b705ffb6edcb1dfd3d#r31435921

lquixada commented 5 years ago

hi! thanks for the PR! can you squash the commit and follow the message pattern from the git history? it should look like this: "moved npm-run-all to devDependencies."

gr2m commented 5 years ago

I’ve seen you have both a package-lock.json and a yarn.lock file? I only updated package-lock.json now, I think you should have one or the other? I guess that’s why the Snyk CI check complains?

lquixada commented 5 years ago

package-lock.json shouldn't exist! it was added by accident.

gr2m commented 5 years ago

can you finish this up? I don’t use yarn myself, I'd need to install it only to create the lock file :)

lquixada commented 5 years ago

hmmm... if you don't use yarn, i think it's easier to do the fix myself if you don't mind. Otherwise once this PR is merged, I'll have to create another commit only to update the yarn.lock with the change you made in the package.json. This is supposed to be a simple change.

gr2m commented 5 years ago

it's easier to do the fix myself if you don't mind

Not at all! You can also edit my PR directly, I do it all the time in my projects

lquixada commented 5 years ago

cool! I'll do that in the terminal, it'll be quicker! Thanks for reporting the issue and the PR!