lrachbau / qa4sm-reader

Reads NetCDF Output file of qa4sm.eodc.eu and creates nice plots.
MIT License
0 stars 0 forks source link

Feedback global.py #2

Closed wpreimes closed 5 years ago

wpreimes commented 5 years ago
wpreimes commented 5 years ago

I think it's a good idea to collect all the default settings in global.py. Also the list of datasets which require scatter plots is good, maybe you can explain the settings a bit more and move the non-dicts to the top. https://github.com/lrachbau/qa4sm-reader/blob/ffb453d0299d98961ef28674eae23e8d0cf6eab1/src/qa4sm_reader/globals.py#L148

lrachbau commented 5 years ago

full name is SMAP L3 I took those names from qa4sm\validator\fixtures\datasets.json - i think they should be changed there first. Anyways, tracy is going to add the pretty names to the metadata, then it will use those instead of falling back to the strings in the globals.py.