search

lrascao / rebar3_gpb_plugin

A rebar3 plugin for automatically compiling .proto files using the gpb protobuf compiler
MIT License
55 stars 37 forks source link

Use gpb_compile:list_io/2 to get target and deps #136

Closed tomas-abrahamsson closed 3 years ago

tomas-abrahamsson commented 3 years ago

Use gpb_compile:list_io/2 to get target output files and dependency file names, to avoid duplicating knowledge of gpb's module renaming options to here.

This addresses #130.

I have only tested this on a very rudimentary level, in a small demo example, so a review might be needed.

lrascao commented 3 years ago

looks good generally, gonna leave this hanging for a bit while i try it out in some projects

lrascao commented 3 years ago

all good, thanks!