search

lrascao / rebar3_gpb_plugin

A rebar3 plugin for automatically compiling .proto files using the gpb protobuf compiler
MIT License
55 stars 37 forks source link

New version of gpb: 4.17.0 #139

Closed tomas-abrahamsson closed 3 years ago

tomas-abrahamsson commented 3 years ago

New version of gpb: 4.17.0

paulo-ferraz-oliveira commented 3 years ago

@tomas-abrahamsson, @lrascao, have you ever considered versioning as "~> 4", for example? If you both agree on the versioning protocol (e.g. semver) rebar3 will keep the reference updated on the consumer and this type of pull request is thus not required. (strict understanding of versioning scope is a must, however)

tomas-abrahamsson commented 3 years ago

I guess that could work. From my part, it has mostly been due to old habits. On the gpb side, it is semver.

paulo-ferraz-oliveira commented 3 years ago

It's happened to me in other "rebar3 plugin" / "lib" combos, which is why I was reminded of it when I saw this pull request. 👍