search

lrascao / rebar3_gpb_plugin

A rebar3 plugin for automatically compiling .proto files using the gpb protobuf compiler
MIT License
54 stars 37 forks source link

New versiof gpb: 4.17.1 #140

Closed tomas-abrahamsson closed 3 years ago

tomas-abrahamsson commented 3 years ago

I've just pushed version 4.17.1 of gpb, but given the discussion in #139, how should we proceed? Will you just change the dependency to "~> 4" like @paulo-ferraz-oliveira suggested and no PR for 4.17.1 would be needed (if I understood right)? Or should I make some PR? (If so, what should it look like?)

lrascao commented 3 years ago

yeah, i guess that works, i'll merge 4.17.0 first and we can try it this way from now on

lrascao commented 3 years ago

just realized that a PR or an issue will still be needed so the new version can be locked, so we'll probably be keeping the same workflow @tomas-abrahamsson, probably your script can now be made a little bit simpler as it no longer needs to update rebar.config

paulo-ferraz-oliveira commented 3 years ago

just realized that a PR or an issue will still be needed so the new version can be locked

Yeah, that's the only downside to it. In any case, when you upgrade a plugin rebar3 doesn't really care about the lock. Good call, though.