lrberge / fixest

Fixed-effects estimations
https://lrberge.github.io/fixest/
362 stars 59 forks source link

run the same model 3 times, the result changes #375

Closed pachadotdev closed 1 year ago

pachadotdev commented 1 year ago

probably I need to format the laptop or something, but this issue with the current CRAN version is very funny

https://github.com/pachadotdev/fixest2/issues/27

lrberge commented 1 year ago

Hi, this problem does not occur with me. There must be a problem with your install I guess. Have you tried with the CRAN version of fixest? (maybe it was a dev one?)

pachadotdev commented 1 year ago

Hi, this problem does not occur with me. There must be a problem with your install I guess. Have you tried with the CRAN version of fixest? (maybe it was a dev one?)

thx, it happens with the CRAN version

lrberge commented 1 year ago

I tried 100s of times, it never happens.... Can't replicate so it may be due to some idiosyncrasy in your install????

pachadotdev commented 1 year ago

it looks to be the case!

I just tried on the Windows laptop and it works well. This happens on Ubuntu and happens with fixest and what I call "fixest2" using cpp11.

Here's I fitted the same model many times and rta_lag8 changes (as well as the other coefficients)

> fixest2::feols(form, data = d)$coefficients
Registered S3 methods overwritten by 'fixest2':
  method         from  
  print.fixest   fixest
  summary.fixest fixest
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
       -779.2721        1414.1179        1699.2425         437.6335       96651.7869 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
      76240.6495       33488.7492       36511.3091       30080.4639 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
       -936.7048         658.0295         760.1958         629.3434      166291.2933 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125759.2310      105727.6196      102431.1845       90034.9268 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        194.9357         708.4649        1440.4936         486.6298      128535.8432 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
      84911.9397       82035.8525       68480.6156       52797.8947 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        529.2569         675.0143        1422.2910        1006.5231      166259.3602 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125797.6555      105768.5744      102423.2779       89986.2683 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        514.7483         662.4080        1613.2392         620.1741      166261.6089 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125802.1392      105770.8193      102425.5205       89988.5079 
> fixest2::feols(form, data = d)$coefficients
             rta         rta_lag4         rta_lag8        rta_lag12 intl_border_1986 
        811.4590         675.0287        1422.2354        1006.3692      166246.0658 
intl_border_1990 intl_border_1994 intl_border_1998 intl_border_2002 
     125784.3651      105755.2896      102396.7450       89973.0010