search

lrberge / fixest

Fixed-effects estimations
https://lrberge.github.io/fixest/
361 stars 59 forks source link

local variable XYZ assigned but may not be used #419

Closed pachadotdev closed 5 months ago

pachadotdev commented 1 year ago

Hi @lrberge

I hope you are well! I am using VSCode and it doesn't like a few things in Methods.R, such as this:

[{
    "resource": "/home/pacha/github/fixest2/R/Methods.R",
    "owner": "_generated_diagnostic_collection_name_#1",
    "severity": 4,
    "message": "local variable ‘dots’ assigned but may not be used",
    "source": "object_usage_linter",
    "startLineNumber": 696,
    "startColumn": 5,
    "endLineNumber": 696,
    "endColumn": 9
}]

Does it make sense that I send a PR? Some of the warnings are "meh", such as "<-" vs "=", but there are a few about assigned objects that are not used.

Take care!

lrberge commented 5 months ago

I don't lint in VSCode, that's annoying. False positive.