search

lrembacz / vue-responsive-grid-layout

Vue Repsonsive Grid Layout
MIT License
83 stars 19 forks source link

Fix reset of layout when changing breakpoints. #6

Closed anders-rv closed 6 years ago

anders-rv commented 6 years ago

It seemed like the grid would sometimes reset the layout for the breakpoint when changing browser width. This code somewhat resolves that problem.

It would probably be good to try to merge the existing coordinates and sizes that have already been set with new additions that do not yet exist in the layout for the new breakpoint.

lrembacz commented 6 years ago

Yes I can see I made mistake with this comparison layout to breakpoint and it's maxlength of layouts to breakpoint. Ill fix it on dev branch for now, beacause I'm preparing this branch to merge it on master. There are events fixes and some async synchronizations done with promises which actually are making reactivness back for vuex support.

If you can please try now dev branch for your issues. I'll prepare some changes and tomorrow will merge them all if evverything will be correctly done.

anders-rv commented 6 years ago

Thanks,

I've tested the dev branch and it seems to work really well. Some small adjustments needed to upgrade, but nothing major and I haven't found any bugs so far.

Looking pretty good!

lrembacz commented 6 years ago

Thank you for you support with that issue. You was right there was the problem with this breakpoint check as well. I have already merged my dev branch into master. Please check changelog for details.