search

lrj689 / pe

0 stars 0 forks source link

DG - still refers to persons #11

Open lrj689 opened 3 years ago

lrj689 commented 3 years ago

Still uses persons

nus-pe-bot commented 3 years ago

Team's Response

Please screenshot the locations where you think this is a legitimate issue. This looks to us like an attempt to game the grading system, especially by giving it high severity.

We have checked, and 28/29 of the instances of "Person" in the DG refer to the class names such as Person and UniquePersonList which are completely valid as those are the class names in our code. The usage of the last instance, while not explicitly referring to a class, still alludes to the concept of a Person, and is a more general form and used appropriately here.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]