search

lrjconan / GRAN

Efficient Graph Generation with Graph Recurrent Attention Networks, Deep Generative Model of Graphs, Graph Neural Networks, NeurIPS 2019
MIT License
462 stars 97 forks source link

Closes #7 division by zero fix #13

Closed KyleAMoore closed 3 years ago

KyleAMoore commented 3 years ago

Fixes the division by 0 error referenced in #7.

I also made a small fix to a type error that I encountered in model/gran_mixture_bernoulli.py, in addition to writing some additional documentation on how to set up the repository after cloning. In particular, I ran into numerous versioning issues due to a major release of networkx and matplotlib being released after this repo was published. I created a conda environments file that enforces a valid combination of dependency versions.

For encapsulation purposes, I have reverted those changes on this branch, and only the division by zero fix is still included in this pull request.

You can view these other changes in the master branch of my fork here. If you like these changes and would prefer that any or all of them be included in the PR, drop a comment and I will add those changes back in or submit a new PR with all of the changes as desired.

lrjconan commented 3 years ago

Fixes the division by 0 error referenced in #7.

I also made a small fix to a type error that I encountered in model/gran_mixture_bernoulli.py, in addition to writing some additional documentation on how to set up the repository after cloning. In particular, I ran into numerous versioning issues due to a major release of networkx and matplotlib being released after this repo was published. I created a conda environments file that enforces a valid combination of dependency versions.

For encapsulation purposes, I have reverted those changes on this branch, and only the division by zero fix is still included in this pull request.

You can view these other changes in the master branch of my fork here. If you like these changes and would prefer that any or all of them be included in the PR, drop a comment and I will add those changes back in or submit a new PR with all of the changes as desired.

Sorry that I merge the PR too quickly to adopt your additional documentation. Do you mind creating another PR to add these documentations to e.g. README.md and requirements.txt? Thanks!