search

lrk / ansible-role-sonarqube

Ansible Role: SonarQube
Apache License 2.0
34 stars 45 forks source link

feat: ability to install plugins from update.sonarsource.org has been added #38

Closed oukooveu closed 3 years ago

oukooveu commented 3 years ago

There is some kind of plugins repository located at https://update.sonarsource.org which is used by SonarQube's marketplace and now plugins can be installed from here. Details are here: https://docs.sonarqube.org/8.9/instance-administration/marketplace.

Old behavior is in place.

oukooveu commented 3 years ago

There is an issue with tests:

CRITICAL Idempotence test failed because of the following tasks:

*  => ansible-role-sonarqube : Ensure SonarQube files permissions

WARNING  An error occurred during the test sequence action: 'idempotence'. Cleaning up.

Trying to understand what's wrong.

oukooveu commented 3 years ago

Issue above introduced by /opt/sonarqube/sonarqube-7.9/temp/conf/es/elasticsearch.keystore

lrk commented 3 years ago

Issue above introduced by /opt/sonarqube/sonarqube-7.9/temp/conf/es/elasticsearch.keystore

you can use changed_when: false for that step, i don't really care, it's just for forcing files permissions. not critical for idempotency.

oukooveu commented 3 years ago

you can use changed_when: false for that step, i don't really care, it's just for forcing files permissions. not critical for idempotency.

it's not clear why we need so strict "og-w" mode so i've changed it to "o-w", and sonar_install_directory has "750" so seems it's not an issue

oukooveu commented 3 years ago

@lrk could you please review?