search

lrkissling / giant-bomb-qol

A simple WebExtension that provides some Quality-of-Life improvements to giantbomb.com.
GNU General Public License v3.0
6 stars 6 forks source link

Opera Support #47

Open kmausolf opened 5 years ago

kmausolf commented 5 years ago

Opera's new Chromium-based browser is pretty hot, and I'd like to port the extension to it. Should be pretty straightforward, as it's based on Chromium.

kmausolf commented 5 years ago

Can you assign me, @lrkissling ?

kmausolf commented 5 years ago

https://dev.opera.com/extensions/publishing-guidelines/ https://dev.opera.com/extensions/basics/

Saving these here for later.

lrkissling commented 5 years ago

https://dev.opera.com/extensions/architecture-overview/

This page is useful for listing things they discourage or disallow. Of concern is that they seriously recommend against using setInterval(), which QB QoL uses for the live stream indicator.

lrkissling commented 5 years ago

If we add Opera support, I will finally want to create a build script so I don't have to manually create the build for each browser. I will create a separate issue for that.

kmausolf commented 5 years ago

That's a great idea. Also, do we have any kind of semantic versioning?

lrkissling commented 5 years ago

No, I've never given versioning that much thought. Going forward maybe we could do whole number versions for new features. Use x.1, x.2, etc for bug fixes, new emotes, and super small tweaks.

kmausolf commented 5 years ago

https://semver.org/

This is an excellent primer for semver. It can be useful for declaring when a change is incompatible with previous versions, and so on.