lronaldo / cpctelera

Astonishingly fast Amstrad CPC game engine for C developers
http://lronaldo.github.io/cpctelera/
GNU Lesser General Public License v3.0
229 stars 54 forks source link

cpct_drawSpriteBlended inconsistent parameter order in Development Branch 1.5 #171

Open davemoore22 opened 10 months ago

davemoore22 commented 10 months ago

From the official documentation, its Height then Width in cpct_drawSpriteBlended but otherwise in all other calls that I can see its Width then Height in the parameters. This is somewhat annoying and obviously inconsistent.

void cpct_drawSpriteBlended (void* memory, u8 height, u8 width, void* sprite) __z88dk_callee;

vs

void cpct_drawSpriteMasked (void* sprite, void* memory, u8 width, u8 height) __z88dk_callee; void cpct_drawSprite (void* sprite, void* memory, u8 width, u8 height) __z88dk_callee;

Also, the other two parameters are swapped about too.