lronaldo / cpctelera

Astonishingly fast Amstrad CPC game engine for C developers
http://lronaldo.github.io/cpctelera/
GNU Lesser General Public License v3.0
229 stars 54 forks source link

Readvideomem #68

Closed Arnaud6128 closed 6 years ago

Arnaud6128 commented 6 years ago

Add "Screen capture to Sprite" function and example (issue #16)

lronaldo commented 6 years ago

Hi @Arnaud6128,

I'm having a look at your code. Your example is simple and neat and is quite convenient. getScreenToSprite works and can be used as is by now, and I also think that we'll be able to improve code efficiency. I also think we need to review documentation for the function for some improvements, but it is okay by now.

Just two things before accepting your pull request:

Thank you for your collaboration, as always. I'm sure a lot of people will benefit from your contributions :)

lronaldo commented 6 years ago

I have already reviewed code and documentation and merged everything into readvideomem branch. Please, take into account comments for your other pull requests and don't forget to fetch changes from this branch into your fork repository.

I have tested everything and seems perfectly fine. I wil shortly merge it into development branch for testers to have the opportunity to use it.

Thank you very much, @Arnaud6128 :)