search

lrstanley / girc

:bomb: girc is a flexible IRC library for Go :ok_hand:
https://pkg.go.dev/github.com/lrstanley/girc
MIT License
138 stars 13 forks source link

Fix IsValidUser() #12

Closed PMaynard closed 6 years ago

PMaynard commented 6 years ago

Fails while checking the first character of name if > J.

codecov-io commented 6 years ago

Codecov Report

Merging #12 into master will decrease coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   56.59%   56.51%   -0.09%     
==========================================
  Files          13       13              
  Lines        2311     2311              
==========================================
- Hits         1308     1306       -2     
- Misses        898      899       +1     
- Partials      105      106       +1
Impacted Files Coverage Δ
format.go 97.16% <100%> (ø) :arrow_up:
conn.go 58.84% <0%> (-0.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e46d210...c42a9b7. Read the comment docs.

lrstanley commented 6 years ago

Yikes! Thanks for noticing that. :+1: