Closed nmeum closed 6 years ago
Merging #13 into master will decrease coverage by
0.3%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 56.77% 56.46% -0.31%
==========================================
Files 13 13
Lines 2311 2313 +2
==========================================
- Hits 1312 1306 -6
- Misses 894 901 +7
- Partials 105 106 +1
Impacted Files | Coverage Δ | |
---|---|---|
event.go | 69.34% <0%> (-0.54%) |
:arrow_down: |
conn.go | 58.84% <0%> (-2.47%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 102f17f...2f79989. Read the comment docs.
Once the invite-notify
fixes are in place, should be good. If there are any others you'd like to see added to pretty
, feel free to submit PR's. I missed a bunch of useful things for sure.
Once the invite-notify fixes are in place, should be good.
In case you missed it: I've done this. Is there anything else which prevents this from getting merged?
Sorry, someone hit my car the other day, and have been super busy planning a trip back home. Haven't had a change to test. Looks good, thanks!
Somehow, there is currently no if-statement for the invite message in the
Pretty()
function of theEvent
type. Thus causing the message to be discarded when invokingPretty()
.This commit adds this missing if-statement to the function.