Typo in documentation and/or source code

lrstanley / girc

:bomb: girc is a flexible IRC library for Go :ok_hand:

https://pkg.go.dev/github.com/lrstanley/girc

MIT License

138 stars 13 forks source link

Typo in documentation and/or source code #17

Closed bmeh closed 5 years ago

bmeh commented 5 years ago

At https://godoc.org/github.com/lrstanley/girc#Event, EmptyTrailign should be EmptyTrailing. I also recommend replacing all occurrences of rfc to RFC, as it is an abbreviation. There is also an inconsistent use of contractions, somewhere you are using the full form, somewhere you are using the contracted form.

lrstanley commented 5 years ago

Fixed spelling mistake. As for rfc->RFC -- have plans to move all of the RFC stuff into a automatically updating/generated ircdefs package, just haven't had the chance. Should have some time within the next few weeks though, as I'm just about finished moving places IRL.

bmeh commented 5 years ago

Oh, hope things are well! :+1:

lrstanley commented 5 years ago

After looking at my uses of "rfc", I won't be making the change. Going off how the IETF references their "rfc#####" more frequently from my brief scans of their sites, it's meh. Still will be moving to an ircdefs separate package which will be auto-generated -- keep an eye out for this.