search

lrstanley / girc

:bomb: girc is a flexible IRC library for Go :ok_hand:
https://pkg.go.dev/github.com/lrstanley/girc
MIT License
139 stars 13 forks source link

Fix IRC color code bug #24

Closed cyruslabs closed 5 years ago

cyruslabs commented 5 years ago

Fix IRC color bug preventing some color codes (e.g cyan) from formatting properly.

Test pass after fix: === RUN TestFormat --- PASS: TestFormat (0.00s) PASS

codecov-io commented 5 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files          13       13           
  Lines        2329     2329           
=======================================
  Hits         1308     1308           
  Misses        913      913           
  Partials      108      108
Impacted Files Coverage Δ
format.go 97.16% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2816e42...9da2a33. Read the comment docs.

lrstanley commented 5 years ago

Nice catch, surprised I didn't see this before. Can you add an additional entry to TestFormat that includes using cyan?

cyruslabs commented 5 years ago

Sure, just updated the branch adding red and cyan tests (one was working before and the other wasn't).

Thanks for this great project by the way! Much appreciated.