search

lrstanley / girc

:bomb: girc is a flexible IRC library for Go :ok_hand:
https://pkg.go.dev/github.com/lrstanley/girc
MIT License
137 stars 13 forks source link

DISCONNECTED event handler is never invoked #26

Closed nmeum closed 5 years ago

nmeum commented 5 years ago

The documentation states the following:

// occurs when we're disconnected from the server (user-requested or not)
DISCONNECTED   = "CLIENT_DISCONNECTED"

However, the code to invoke handlers registered for this constant seems to have been removed in 4951996f3ac75196db1712bacb1841dcacb33eb1. The DISCONNECTED constant is currently not used anywhere in the code base.

Not sure if you simply forgot removing the constant in 4951996f3ac75196db1712bacb1841dcacb33eb1...