search

lrstanley / girc

:bomb: girc is a flexible IRC library for Go :ok_hand:
https://pkg.go.dev/github.com/lrstanley/girc
MIT License
137 stars 13 forks source link

No need to make lookupUser argument RFC 1459 compliant #31

Closed nmeum closed 5 years ago

nmeum commented 5 years ago

The lookupUser function already converts the argument to an RFC 1459 compliant nick and there is no need to convert it twice.

codecov-io commented 5 years ago

Codecov Report

Merging #31 into master will not change coverage. The diff coverage is 57.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   56.05%   56.05%           
=======================================
  Files          13       13           
  Lines        2335     2335           
=======================================
  Hits         1309     1309           
  Misses        919      919           
  Partials      107      107
Impacted Files Coverage Δ
cap.go 22.77% <0%> (ø) :arrow_up:
builtin.go 60.8% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14ace77...bdce274. Read the comment docs.