lrstanley / girc

:bomb: girc is a flexible IRC library for Go :ok_hand:
https://pkg.go.dev/github.com/lrstanley/girc
MIT License
137 stars 13 forks source link

WebIRC #33

Closed qaisjp closed 5 years ago

qaisjp commented 5 years ago

I currently use https://github.com/thoj/go-ircevent/ where I implemented WebIRC support in https://github.com/thoj/go-ircevent/pull/96.

I am interested in girc and would like to add WebIRC support.

Is this fine?

lrstanley commented 5 years ago

Are the fields always consistent? e.g. user, hostname, ip should always be provided? If so, may want to make a custom WebIRC type that the user specifies, with those fields.

qaisjp commented 5 years ago

All are required

lrstanley commented 5 years ago

Let me know how https://github.com/lrstanley/girc/commit/c1e59a02f4889054b185088cb6ed79db9641251c works for you. Wanted to be a little be more descriptive.

qaisjp commented 5 years ago

Looks good, cheers!