search

lrstanley / girc

:bomb: girc is a flexible IRC library for Go :ok_hand:
https://pkg.go.dev/github.com/lrstanley/girc
MIT License
139 stars 13 forks source link

use JoinHostPort() in client.Server() #40

Closed nmeum closed 5 years ago

nmeum commented 5 years ago

This fixes a bug where girc would fail to connect (with the error message "too many colons in address") if the server was specified as an IPv6 address since appending a colon is not enough in that case.

codecov-io commented 5 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.12%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   56.31%   56.18%   -0.13%     
==========================================
  Files          13       13              
  Lines        2321     2321              
==========================================
- Hits         1307     1304       -3     
- Misses        910      912       +2     
- Partials      104      105       +1
Impacted Files Coverage Δ
client.go 70.27% <100%> (ø) :arrow_up:
conn.go 58.53% <0%> (-0.82%) :arrow_down:
builtin.go 60.67% <0%> (-0.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e71da9d...6a0f21c. Read the comment docs.

lrstanley commented 5 years ago

Merged in https://github.com/lrstanley/girc/commit/33f2d454a54d181377ce6797a2ae02824689778d -- thanks!