search

lrucker1 / XTideMac

XTide for macOS, iOS, and watchOS
7 stars 3 forks source link

IOS version crashes when loading HARMONICS_NO_US.tcd from opencpn #3

Open tljohnsn opened 1 year ago

tljohnsn commented 1 year ago

I have a few custom harmonic files but I can't get any of them to load into the ios app. It just exits the app when I choose them. The same files load just fine into the mac version of XTide, and also work just fine in opencpn.

Thanks for the great port, it's working well for me so far on the mac but would be nice to have the tides on my mobile.

lrucker1 commented 1 year ago

Sorry to hear that, could you send me one of the files that causes the crash?

On Feb 25, 2023, at 6:52 AM, tljohnsn @.***> wrote:

I have a few custom harmonic files but I can't get any of them to load into the ios app. It just exits the app when I choose them. The same files load just fine into the mac version of XTide, and also work just fine in opencpn.

Thanks for the great port, it's working well for me so far on the mac but would be nice to have the tides on my mobile.

— Reply to this email directly, view it on GitHub https://github.com/lrucker1/XTideMac/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESOQZUWDIVAWJP5JBHWWXLWZIMCZANCNFSM6AAAAAAVH4YTTA. You are receiving this because you are subscribed to this thread.

tljohnsn commented 1 year ago

HARMONICS_NO_US_Consort.tcd.gz

tljohnsn commented 1 year ago

Thank you - the above created with the latest tcd utils from: HARMONICS_Racoon.xml.gz HARMONICS_NassauOnly.txt

lrucker1 commented 1 year ago

Thanks! It looks like Apple changed part of the file opening process without providing backward compatibility. After implementing the missing functionality your file opened with no problems. I’ll let you know when it hits the AppStore.

On Feb 25, 2023, at 3:53 PM, tljohnsn @.***> wrote:

HARMONICS_NO_US_Consort.tcd.gz https://github.com/lrucker1/XTideMac/files/10832542/HARMONICS_NO_US_Consort.tcd.gz — Reply to this email directly, view it on GitHub https://github.com/lrucker1/XTideMac/issues/3#issuecomment-1445229362, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESOQZQJC6YUB75KSNAM633WZKLPDANCNFSM6AAAAAAVH4YTTA. You are receiving this because you commented.

tljohnsn commented 1 year ago

Great - Thank you!

lrucker1 commented 1 year ago

It’s on the AppStore now.

On Feb 26, 2023, at 3:20 AM, tljohnsn @.***> wrote:

Great - Thank you!

— Reply to this email directly, view it on GitHub https://github.com/lrucker1/XTideMac/issues/3#issuecomment-1445334694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESOQZR7UTXSTYE4OA2JICDWZM375ANCNFSM6AAAAAAVH4YTTA. You are receiving this because you commented.

tljohnsn commented 1 year ago

Hmm - I am still getting the crash after updating, as well as a fresh install from another device. I can't seem to find what version I actually have installed.

Thanks for any help. Trent

lrucker1 commented 1 year ago

I’ve reproduced it, it turned out to be an interesting edge case: it all depended on where the file was in the file system. When I dragged it onto my device it was getting added to XTide’s Sandbox folder, but when I reproduced the crash it was in the general Documents folder.

The problem is that when you choose a file from outside the Sandbox, the file chooser calls into your code with the filepath before it’s actually been approved. I was trying to get info about the file before I had permission to read it. It “crashed” because the original XTide was a Unix command-line app, where it’s perfectly acceptable to exit if it thinks you’re doing something weird like trying to open a file that doesn’t appear to exist. I thought I’d caught all the unexpected exits but this slipped through.

That’s also why I couldn’t find anything in the AppStore crash logs - “exit” doesn’t count as a crash.

I’m starting the AppStore process now.

On Feb 28, 2023, at 4:05 AM, tljohnsn @.***> wrote:

Hmm - I am still getting the crash after updating, as well as a fresh install from another device. I can't seem to find what version I actually have installed.

Thanks for any help. Trent

— Reply to this email directly, view it on GitHub https://github.com/lrucker1/XTideMac/issues/3#issuecomment-1448068668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESOQZX77EG5NMJM7ZQNJNLWZXSZXANCNFSM6AAAAAAVH4YTTA. You are receiving this because you commented.

tljohnsn commented 1 year ago

Great, that makes sense. After reading this I tried air dropping the file directly to the device and opening directly with xTide and it worked fine. I can see my stations now.

Thanks again, I will try the new version once it drops.

lrucker1 commented 1 year ago

Latest version is up, thanks for all your patience!

On Mar 2, 2023, at 2:54 AM, tljohnsn @.***> wrote:

Great, that makes sense. After reading this I tried air dropping the file directly to the device and opening directly with xTide and it worked fine. I can see my stations now.

Thanks again, I will try the new version once it drops.

— Reply to this email directly, view it on GitHub https://github.com/lrucker1/XTideMac/issues/3#issuecomment-1451673716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESOQZQFOQRUPJW7PJZUDQDW2B35FANCNFSM6AAAAAAVH4YTTA. You are receiving this because you commented.