search

lrug / lrug.github.io

The README for everything you'd want to know about LRUG
http://readme.lrug.org
Other
0 stars 8 forks source link

"several good resources online" links to the same article twice #18

Closed dwo closed 10 years ago

dwo commented 10 years ago

index.md, line 45, the link to http://www.shakesville.com/2010/01/feminism-101.html appears twice.

Intentional, or was there another article intended for one of those anchors?

aanand commented 10 years ago

Hm, good point. @timcowlishaw?

timcowlishaw commented 10 years ago

D'oh, sorry. The final link was meant to be to the JSconfEU Code of conduct, but since it's pretty much identical to the pycon one, I ommitted it, and forgot to remove the anchor tag. I'll make a PR and amend - I also want to tweak this paragraph slightly so we haven't got four links with nothing but whitespace in between, as this can cause accessbibility problems, so will address this at the same time.

h-lame commented 10 years ago

@timcowlishaw we've fixed the double link, but your last comment suggests there were further tweaks you wanted to make. Have you had a chance to work on it?

timcowlishaw commented 10 years ago

Oops, sorry @h-lame - totally slipped my mind! Just filed PR #24 to fix.

h-lame commented 10 years ago

Ok, with #24 and #20 we can call this closed. Thanks @dwo for noticing, @timcowlishaw and @chrislo for fixing.