search

lrug / lrug.org

The middleman app we use to generate lrug.org
https://lrug.org
Other
17 stars 31 forks source link

Generate ics file for recent events #348

Closed fcheung closed 2 months ago

fcheung commented 2 months ago

This replaces the calendar link with an ics file derived from meeting data, hopefully in a way that will work nicely with https://github.com/ruby-conferences/ruby-conferences.github.io/pull/735/files

This is very arbitrarily the last 12 months. Generating this file for all time only takes a fraction of a second (and results in ~ 70k of data) but it seems a little obtuse to require people to parse details of lrug meetings from 2006

h-lame commented 2 months ago

I guess we could get @marcoroth's opinion here - if this ICS is a rolling 12 month view on LRUG meetings (most likely the 11 most recent past meetings and 1 upcoming one, or 12 most recent past ones) would that remove entries from rubyconferences.org's listings as they fall off the ics file? What's your take on us generating an ics with all our meetings going back to 2006?

fcheung commented 2 months ago

I guess we could get @marcoroth's opinion here - if this ICS is a rolling 12 month view on LRUG meetings (most likely the 11 most recent past meetings and 1 upcoming one, or 12 most recent past ones) would that remove entries from rubyconferences.org's listings as they fall off the ics file? What's your take on us generating an ics with all our meetings going back to 2006?

I don't think events will get removed. It does remove missing_events but that is defined as upcoming events that are not in the calendar data ( https://github.com/ruby-conferences/ruby-conferences.github.io/blob/3f670c31dcf0229601fb96c50d473c50849e0a52/src/static/meetup_group.rb#L41 )

marcoroth commented 2 months ago

I don't think events will get removed. It does remove missing_events but that is defined as upcoming events that are not in the calendar data ( https://github.com/ruby-conferences/ruby-conferences.github.io/blob/3f670c31dcf0229601fb96c50d473c50849e0a52/src/static/meetup_group.rb#L41 )

Correct, past events don't need to appear again, we only remove upcoming events that don't appear in the source anymore.

So if you do a rolling view of the past 12 months + all upcoming ones (or just the past 12 events) you should be good.

Also, thanks for taking this on! 🙏🏼

fcheung commented 2 months ago

I don't think events will get removed. It does remove missing_events but that is defined as upcoming events that are not in the calendar data ( https://github.com/ruby-conferences/ruby-conferences.github.io/blob/3f670c31dcf0229601fb96c50d473c50849e0a52/src/static/meetup_group.rb#L41 )

Correct, past events don't need to appear again, we only remove upcoming events that don't appear in the source anymore.

So if you do a rolling view of the past 12 months + all upcoming ones (or just the past 12 events) you should be good.

Also, thanks for taking this on! 🙏🏼

Cool - thanks for confirming