ls- / ls_Toasts

Development repository of ls: Toasts
Other
27 stars 3 forks source link

wlk bug #44

Closed shenhix closed 2 years ago

shenhix commented 2 years ago

The wlk version will cause the Blizzard native prompt box to disappear! Cancelling the achievement prompt cannot be restored, it can only be disabled!

ls- commented 2 years ago

It's not a bug, it's an intended behaviour. It's mentioned in my FAQ, but I'll explain it once more. The addon completely replaces the default alert system, so when you disable something the addon just stops showing toasts of that particular type, entirely it won't re-enable Blizz toasts of that kind. It's done for multiple reasons, but the gist of it is that it's just due to how Blizz write their stuff, it can be hard or even impossible to re-enable certain types of toasts without messing up everything else.

-- edit

That said, what do you not like about my achievement toasts? Feedback is always welcome 😁

Velarax commented 2 years ago

As of 10/22/22 cannot get the interface by typing either /lst or /lstoasts; either returns a message: Type '/help' for a listing of a few commands.

s890214 commented 2 years ago

yes,your achievement toasts not cool,default alert system is better,but only achievement toasts,

ls- commented 2 years ago

@Velarax I'll check it out, thanks. I don't play wotlk classic, so I wasn't aware...

-- edit

Everything works just fine O_o

image

Velarax commented 2 years ago

I cannot get the interface to load no matter what I do. :(

ls- commented 2 years ago

@Velarax any errors? Does the addon work? Is it even loaded? If it tells you that you need to try /help for the list of commands, it means that my addon basically failed to load for whatever reason. Did you try deleting its settings from the WTF folder? They're in WTF/Account/YourAccName/SavedVariables, delete both ls_Toasts.lua and ls_Toasts.lua.bak.

ls- commented 2 years ago

@s890214 I'm not mixing my toasts with the default ones, it's a recipe for disaster. Is there anything in particular you don't like about my achievement toasts?

Velarax commented 2 years ago

Although the addon apparently is checked for loading, it is not functioning at all. I already deleted both the cache and the .lua and .lua.bak files.

Typing /lstoasts gets the standard /help? message, so apparently it isn't loading. I have tried disabling other addons to see if there is any conflict, but that doesn't appear to be the case.

ls- commented 2 years ago

Try /dump IsAddOnLoaded("ls_Toasts"), it should return 2 trues. Also try /dump not not ls_Toasts, it should return true.

ls- commented 2 years ago

Btw, are you sure you have the correct version installed? Double check that you don't run retail or vanilla version of the addon. I've seen it a couple of time that addon managers pulled the wrong version of the addon for some reason.

Velarax commented 2 years ago

DOH! That was it, I feel stupid. Thanks.

ls- commented 2 years ago

@Velarax ahahah, it happens, can't fault you, it's like the 3-5 time I run into this issue. Do you by any chance use wowup? and where from do you download it? wago? cf? wowi?

Velarax commented 2 years ago

Actually curse is the culprit. I manually updated the one they had uploaded as "wrath." I see it's been fixed now.

BTW retail is unplayable without your addon. And I love the Classic and Wrath versions too, though announcements in those iterations aren't quite as obnoxious. Anyway, thanks for the addon.

s890214 commented 2 years ago

@s890214 I'm not mixing my toasts with the default ones, it's a recipe for disaster. Is there anything in particular you don't like about my achievement toasts?

your achievement toasts is too ordinary. It should be different from the toasts, Such as size and time It's not easy to detect right now, Because it's just like any other

db98e1832e2e2a9989d6703bbb6c8e82

ls- commented 2 years ago

I'll look into making it more ornate, prob an extra overlay. Something similar to the leaves on the default achievement frame.

achievement

But I'll do that only after I'm done dealing with the income sh*tshow that's the DF prepatch release 😁 The first few weeks after its release will be "fun" 😒🔫

Them all being of the same size is a design choice. I do allow for multiple anchors that have separate scale controls tho.

ls- commented 2 years ago

Old: image image

New: image image

This is my attempt to make my achievement toasts a bit fancier. A compromise of sorts because I'm def not reenabling Blizz achievement toasts.