ls- / ls_Toasts

Development repository of ls: Toasts
Other
27 stars 3 forks source link

Request : Guild Achievements Spam Disable #68

Closed WingZeroMaster closed 2 months ago

WingZeroMaster commented 2 months ago

Request : Guild Achievements Spam Disable I wish there was a way to disable guild achievements spam. because Blizzard's guild achievement notifications spam bug.....

Taizunz commented 2 months ago

Duplicate. I requested this in April: https://github.com/ls-/ls_Toasts/issues/59

ls- commented 2 months ago

So far, I think I'll just add toggles to disable toasts for guild achievements and already earned achievements.

Sorry, my health isn't great atm, had a surgery last week, still recovering, and I just wanna play wow for now without dealing with addons.

ls- commented 2 months ago

I need some help from either of you since I'm not sure how this stuff works, it's been a while since I was in any guild, so I've never experienced this bug first hand. When a toast for a buggy guild achievement pops up, how does it look? Like, do you see the number of points? Is the border yellow? Or it's just blank with a grey border like a proper toast for repeated achievements?

WingZeroMaster commented 2 months ago

WoWScrnShot_091124_012916

(Sorry for the Google Translate....) Being healthy is the most important!!! :) The screenshot below is the screen when the guild achievement bug occurs. In addition, the addons below are said to be addons to block the bug. I think it would be good to refer to them. thank you for nice addon. https://www.curseforge.com/wow/addons/guildachievementblocker https://www.curseforge.com/wow/addons/disableguildachievements

ls- commented 2 months ago

I checked all those addons to get the answer, but most of them either don't work or don't answer the question 😂 Can't open the screenshot, but the thumbnail was good enough to see that what the addon saw was basically a brand new achievement and not a repeat 😅

Anyway, I'm currently testing two toggles to suppress repeats for character and guild achievements, I don't think account achievements can generate repeats 🤔

Hopefully, this will fix the issue.

-- edit

Ignore what I said there, I should've rested some more instead of trying to deal with this stuff. The only time a guild achievement shows a repeat is when it's bugged. But yeah, I have a fix for this bs.

ls- commented 2 months ago

Fixed, it'll be released with the next update, but not today.

ls- commented 2 months ago

The previous workaround only worked under very specific circumstances, so I had to rework it. I even joined a guild where people were regularly experiencing the bug so I could investigate the cause properly.

With the next update I'll be adding an optional filter for guild achievements, unfortunately, there's no way to reliably automate it without affected people in newer guilds who might want to see these achievements.

image