search

ls- / ls_UI

Development repository of ls: UI
Other
44 stars 7 forks source link

Significant bug in text format handling #40

Closed klaxce closed 6 years ago

klaxce commented 6 years ago

If you put an incorrect text tag in the Format field of the Target Frame Power element then you can cause the minimap to not be reskinned/repositioned, as well as unable to edit the Focus, Target of Focus and Boss Frames. You may have to reload/relog after applying the incorrect text formatting in order for it to break things.

ex. [ls:color:power][ls:power:perc] works and everything is fine, but if you do [ls:power:color][ls:power:perc] then it breaks things as described (power/color are reversed).

I haven't tested this in other Format fields.

ls- commented 6 years ago

Hm, I'll test it a bit later today...

TY for the report <3

ls- commented 6 years ago

Got it.

[ls:power:color] isn't a legit tag, so when you try to use it this error: 1x ...acels_UI\modules\unitframes\units\player-Player.lua:36: Attempted to use invalid tag [ls:power:color].

Technically, it's not a bug, it's the intended behaviour. I may add tag string validation though...

ls- commented 6 years ago

On a side note, you should prob install BugSack and BugGrabber, by default, Blizz lua error reporting is disabled.

klaxce commented 6 years ago

The expected behavior of a malformed tag shouldn’t be to break half of the addon. So anything that stops that would be great. To be fair, I didn’t actually have Lua errors turned on and so it took me a few profile resets to figure out what was causing the addon to break. I hadn’t realized that the tags were static and not dynamically accepting arguments, so I had tried to shorten my tag to set power text and color in one tag.

On Aug 12, 2018 at 01:55, <Val Voronov (mailto:notifications@github.com)> wrote:

Got it.

[ls:power:color] isn't a legit tag, so when you try to use it this error: 1x ...acels_UI\modules\unitframes\units\player-Player.lua:36: Attempted to use invalid tag [ls:power:color].

Technically, it's not a bug, it's the intended behaviour. I may add tag string validation though...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/ls-/ls_UI/issues/40#issuecomment-412328659), or mute the thread (https://github.com/notifications/unsubscribe-auth/AObmtBioEPcZ7fLB6sAZ2KJb70EOY9iAks5uP-1tgaJpZM4V5ECd).

ls- commented 6 years ago

K, now if you try to use something like this: [ls:health:cur][tag #1] [tag #2], tag setter won't update the string, and you'll see a message like this in the config's status bar: Imgur