search

ls-age / svelte-preprocess-sass

Svelte preprocessor for sass
91 stars 6 forks source link

Move from `node-sass` to `sass` #112

Closed EMH333 closed 3 years ago

EMH333 commented 3 years ago

One of the biggest things I noticed when using this preprocessor is the required installation of node-sass. node-sass is deprecated (see README) and brings in a ton of dependencies (if I remember it added 100+ to one of my projects, many outdated) that cause unneeded bloat for a simple project. Additionally it requires native libraries which is less appealing for CI or other systems.

The npm sass package is officially recommended by the SASS team and is compiled from the Dart version meaning it tends to get updates quicker. Additionally it has the same API so it should just be a drop-in replacement. Performance also is fairly nominal.

I'd be happy to take a swing at replacing it or could also support either of them so the end user gets to decide.

Thanks!

EMH333 commented 3 years ago

@LukasHechenberger Thoughts?

LukasHechenberger commented 3 years ago

Yeah, i already noticed, I'll patch it as soon as possible. Thanks for reminding and sorry for the delay.

LukasHechenberger commented 3 years ago

Released in v2.0.0 🎉 Thanks for contributing!