search

ls1intum / Apollon

UML Modeling Editor written in React
https://apollon-library.readthedocs.io
MIT License
67 stars 22 forks source link

Feature/resizing from all corners #207

Closed minrows closed 2 years ago

minrows commented 2 years ago

Checklist

Motivation and Context

This feature enables resizing of an elements from all 4 corner. Issue Number: https://github.com/ls1intum/Apollon/issues/71

Description

Previously resizing of an element could be done only from the bottom right corner. This feature will now enable users to resize it from all 4 corners.

Steps for Testing

  1. Open up Apollon and add any Elements
  2. Try resizing from all corners

Screenshots

screen-capture (5)

martindevtum commented 2 years ago

Code looks good! Way nicer.

martindevtum commented 2 years ago

Still one more bug:

Currently: For Elements that can only be scaled in their Y-Axis, e.g. Petri Net Transitions, those elements get repositioned when resized from the Top Left and Bottom Left Corners.

Should Be: Equivalently to the Bottom Right and Top Right Corners, an element should not be repositioned when they are being resized.

Please fix this issue.

Other than that it looks and feels great.

martindevtum commented 2 years ago

feature works as expected. I approve of the code changes. 👍