search

ls1intum / Apollon

UML Modeling Editor written in React
https://apollon-library.readthedocs.io
MIT License
67 stars 22 forks source link

Bugfix: Boundary of some elements cease to exist while resizing #210

Closed minrows closed 2 years ago

minrows commented 2 years ago

…ments

Checklist

Motivation and Context

To specify the named bounds so that the issue with vanishing element boundary, while resizing is resolved. Issue Number: https://github.com/ls1intum/Apollon/issues/208

Description

Steps for Testing

  1. Open Apollon
  2. Select Activity Diagram from Diagram Type
  3. Drag Activity Action node to the canvas and start reducing its width/height
  4. Observe that the element now no longer vanishes while its side is reduced as it used to (see: https://github.com/ls1intum/Apollon/issues/208 ).

Screenshots

screen-capture-_7_

bassner commented 2 years ago

I tested this locally and it seems to work well, except for packages (class diagram), which can still cut off their text content vertically: grafik But I'm not 100% sure if that was even the point of this PR or if it was just about keep the correct width on certain objects?

minrows commented 2 years ago

Done. Minimum height is now calculated based on the name as well.

martindevtum commented 2 years ago

looking good