search

ls1intum / Apollon

UML Modeling Editor written in React
https://apollon-library.readthedocs.io
MIT License
65 stars 22 forks source link

Drawing Lines #235

Closed isleyenufuk closed 2 years ago

isleyenufuk commented 2 years ago

I dont know if it is wanted but it sure as hell is annoying, if you draw a relationship between two objects or whatever it snaps to a different edge of the desired object.

krusche commented 2 years ago

Can you please provide more details?

b-fein commented 2 years ago

I’d expect the association to be between the two blue half-circles I dragged between. Instead the line snaps most of the time to the top of the element, sometimes to other edges. I’ve had several student complaints about that today as well.

https://user-images.githubusercontent.com/64250573/170363823-9b17d206-10f5-4d22-b1b6-fa626073671f.mp4

https://user-images.githubusercontent.com/64250573/170366572-c376340e-e6b4-4de9-ae13-4bf916ac3384.mp4

minrows commented 2 years ago

Hi @b-fein, I am having a look at the issue. A question though, is it the firefox that you used to attach the provided example?

b-fein commented 2 years ago

Thanks! Yes it is the latest Firefox 100.

minrows commented 2 years ago

Duplicate of https://github.com/ls1intum/Apollon/issues/87

minrows commented 2 years ago

@b-fein, the issue will be fixed once the PR is merged.

On a side note, as firefox is not fully supported, please use another browser if possible. Thanks. 👍

b-fein commented 2 years ago

Thanks a lot, I did not see that an issue and PR were already created.

I’m aware that non-Chrome browsers are not officially supported for Apollon. The students using it from within Artemis don’t, though.

minrows commented 2 years ago

Fixed by https://github.com/ls1intum/Apollon/pull/174

BaumiCoder commented 2 years ago

I tested with the actual code from the develop branch local with yarn (version 1.22.15). The error in firefox 101.0 64-Bit (OS: Linux Mint) still appear. Is that already know or why #87 isn't closed yet?