`Development`: Add manual waypoints feature

ls1intum / Apollon

UML Modeling Editor written in React

https://apollon-library.readthedocs.io

MIT License

65 stars 22 forks source link

`Development`: Add manual waypoints feature #253

Closed minrows closed 2 years ago

minrows commented 2 years ago

Checklist

[x] I added multiple screenshots/screencasts of my UI changes

Motivation and Context

This PR introduces new feature in Apollon. With this PR, users can add waypoints in connectors while drawing diagrams. Feature requested issue Number: https://github.com/ls1intum/Apollon/issues/93

Steps for Testing

In local machine:

Clone the repo
Checkout out feature/manual-waypoints branch
Start application by executing yarn install followed by yarn start command
Add and connect any elements in canvas
Observe waypoints handles and drag to change them

In test server

[x] Will be deployed in test server after releasing alpha version
[x] Disable Manual layouting in "Interactive Mode"
[x] Fix NaN Issue
[x] Fix RTC issue

Screenshots

screen-capture (21)

Additional Info

Changes released in 2.11.4-alpha.0

akesfeden commented 2 years ago

Tested on test server, in the screenshot below I can only see (and interact with) 2 connectors with waypoints, the others are not draggable. Is there a specific condition to create waypoints or all connectors should have them?

minrows commented 2 years ago

Tested on test server, in the screenshot below I can only see (and interact with) 2 connectors with waypoints, the others are not draggable. Is there a specific condition to create waypoints or all connectors should have them?

Ahh, that's intended @akesfeden. Manual layout handlers are only assigned when the line segments of connections (number of bents) are greater than 2. For other cases (less than 2), we do not allow the manual layouting as user can simply drag the elements instead of connectors.

akesfeden commented 2 years ago

I see, thanks for the explanation. In the case below, wouldn't it be nicer if we can also move the segments that are directly connecting to the elements? Maybe that can be considered as an enhancement.

minrows commented 2 years ago

I see, thanks for the explanation. In the case below, wouldn't it be nicer if we can also move the segments that are directly connecting to the elements? Maybe that can be considered as an enhancement.

User can still change the position of connectors (top, bottom, left and right) for the case of line segments that are directly connecting to the elements.
And if allowed, the only position that user could drag line segment connecting to elements would be the width (for top and bottom) and height (for left and right) of an element, so I personally don't think that would give much flexibility.
But yes, it could be considered as an enhancement in follow up PR. Thanks for the feedback (: