`Development`: Fix issue for exporting manually layouted diagram - Githubissues

ls1intum / Apollon

UML Modeling Editor written in React

https://apollon-library.readthedocs.io

MIT License

65 stars 22 forks source link

`Development`: Fix issue for exporting manually layouted diagram #262

Closed minrows closed 2 years ago

minrows commented 2 years ago

Checklist

[x] I added multiple screenshots/screencasts of my UI changes

Motivation and Context

This PR fixes an issue with the cut-off of elements of a manually layouted diagram.

Description

Issue Number: https://github.com/ls1intum/Apollon/issues/258

Steps for Testing

Clone the repo
Checkout to branch bugfix/export-fix
Start the application by executing yarn install followed by yarn start
Insert any two elements and connect them in the canvas in a way that they have manual waypoint connectors (more than 2 edges).
Layout the connector manually
Export the diagram by clicking on the All button from Export Menu on side menu
Observe that all diagram elements are visible with no cut-off.

Screenshots

Before:

screen-capture (15)

After:

screen-capture (14)

minrows commented 2 years ago

Tested on test server, export seems to work as expected however when I reload the page the model seems shifted outside of the view: What I draw:

After reload:

Thank you for your feedback @akesfeden. 👍 The shifting of the diagram while reloading is not brought up by this PR (checked and confirmed in the previous version). The issue could be handled in follow-up PR.