`Development`: Fix cropped out example solution in Artemis issue - Githubissues

ls1intum / Apollon

UML Modeling Editor written in React

https://apollon-library.readthedocs.io

MIT License

65 stars 22 forks source link

`Development`: Fix cropped out example solution in Artemis issue #264

Closed minrows closed 1 year ago

minrows commented 2 years ago

Checklist

[x] I added multiple screenshots/screencasts of my UI changes

Motivation and Context

This PR fixes the issue of cropped-out example solution in Artemis. Issue: https://github.com/ls1intum/Artemis/issues/5639

Description

Steps for Testing

This PR needs to be tested on Artemis.

Deploy this version to one of the test server of Artemis
Create new Modeling Exercises by going to administration > Exercises > Create new Modeling Exercise
Fill out the necessary fields
While setting the example solution, enter two elements into the canvas and connect them
Layout the connector manually and save it
Observe that the connector is not cropped out anymore in example solution section of the exercise preview page

Screenshots

Before

screen-capture (21)

After

screen-capture (22)

bassner commented 2 years ago

For me, it changes the position of the connector after a reload. Intended?

https://user-images.githubusercontent.com/23171488/189682600-82bf3e21-0335-4787-b9ff-63bfbc156d1f.mov

minrows commented 1 year ago

For me, it changes the position of the connector after a reload. Intended?

Screen.Recording.2022-09-12.at.16.36.13.mov

Fixed in https://github.com/ls1intum/Apollon/pull/264/commits/7bdd14696343ccf82ebb42f1c635181859af9e54