search

ls1intum / Apollon

UML Modeling Editor written in React
https://apollon-library.readthedocs.io
MIT License
65 stars 22 forks source link

`Development`: Fix issue with interface marker while exporting diagram #269

Closed minrows closed 1 year ago

minrows commented 1 year ago

Checklist

Motivation and Context

The appearance of the required interface marker was not displayed correctly (as implemented by PR )when the diagram was exported (PDF, SVG, ...). This PR fixes an issue with the appearance of the required interface marker while exporting the diagram.

Steps for Testing

Local Machine

  1. Clone the repository
  2. Checkout to the branch bugfix/pdf-export-issue
  3. Start the application by executing yarn install followed by yarn start commands.
  4. Select Component Diagram as DiagramType
  5. Insert Interface and Component in the canvas
  6. Connect component and interface using required interface connector.
  7. Export the diagram by clicking on All from Export menu.
  8. Observe that the semicircle marker is used as illustrated in the screenshot section.

Testing Server

  1. Goto test server
  2. Create new Component Diagram by clicking on File > New > Component Diagram
  3. Insert Interface and Component in the canvas
  4. Connect component and interface using required interface connector.
  5. Export the diagram by clicking File > Export > As PDF (or any format).
  6. Observe that the semicircle marker is used as illustrated in the screenshot section.

Screenshots

Before

screen-capture (3)

After

screen-capture (4)

PS: Changes released in version 2.12.5-alpha.3

4ludwig4 commented 1 year ago

Mhh tried to test it on the testserver you provided and it doesn't even look like it looked before?!

Screenshot from 2022-11-07 14-07-42

Resulting Pdf also has wrong boundries:

ComponentDiagram.pdf

Client Environment: Ubuntu Chromium 107.0.5304.87 (Official Build) snap (64-bit)

minrows commented 1 year ago

Seems like you're using the "Provided Interface" instead of "Required Interface". Could you please use "required interface" instead?

4ludwig4 commented 1 year ago

Ah thanks, I didn't know how to get to the "required Interface". Just found out that I get there via double click.

Then it seems to be working except the boundary problem, but that's probably another problem?!

ComponentDiagram (1).pdf

minrows commented 1 year ago

Thanks @4ludwig4 . And yes, the other issue will be fixed in separate PR.