Unsaved changes not recognised when dismissing popover

ls1intum / Apollon

UML Modeling Editor written in React

https://apollon-library.readthedocs.io

MIT License

65 stars 22 forks source link

Unsaved changes not recognised when dismissing popover #28

Closed jwilland-tum closed 3 years ago

jwilland-tum commented 5 years ago

Current behaviour

If a popover contains unsaved changes, like a new attribute or method for UML class elements, and the user dismisses the popover by clicking anywhere outside the popover, the changes are not saved.

Expected behaviour

Save the changes on dismissing the popover.

Environment

Apollon 2.0.0-rc.4

jwilland-tum commented 5 years ago

Currently, we listen on the blur event of the input element to save changes. Apparently, there seems to be a bug in react that prevents the blur event from firing when the element is removed from the DOM tree (https://github.com/facebook/react/issues/12363). To solve this issue we are currently investigating workarounds.

TobiasPr commented 3 years ago

bugfix in bugfix/unsaveg_changes_dismissed_in_popover waiting for more tests before integrating the fix

TobiasPr commented 3 years ago

integrated today, will be included in the next release