ls1intum / Apollon

UML Modeling Editor written in React
https://apollon-library.readthedocs.io
MIT License
61 stars 21 forks source link

`Feature`: Event and Task Type Selection #321

Closed matthiaslehnertum closed 7 months ago

matthiaslehnertum commented 7 months ago

This PR extends Apollon by the ability to select event types more specific than just start, intermediate and end events.

Screenshot 2023-11-23 at 13 52 55

Start Event

Update dialog of the Start Event

Screenshot 2023-11-19 at 17 47 02

All available Start Event types

Screenshot 2023-11-19 at 17 47 57

Intermediate Event

Update dialog of the Intermediate Event

Screenshot 2023-11-19 at 17 50 03

All available Intermediate Event types

Screenshot 2023-11-19 at 17 49 54

End Event Update dialog of the End Event

Screenshot 2023-11-19 at 17 50 58

All available End Event types

Screenshot 2023-11-19 at 17 51 10

Checklist

Motivation and Context

To fully comply with the BPMN 2.0 standard, events and tasks need to allow for specifying specialisations.

Steps for Testing

For Events Drag any event onto the canvas, double click it and select an event type.

For Tasks Drag any task onto the canvas, double click and select a task type.

loreanvictor commented 7 months ago

ok the functionality seems to work as intended, saving / loading state works, exporting works fine for the new elements and tests are passing. I would have a few small suggestions (some of these can also be added on a follow up PR I suppose):

ezgif com-video-to-gif-4

matthiaslehnertum commented 7 months ago

@loreanvictor I increased the test coverage, thank you for the remark! The incorrect positioning of the update dialog seems to be a general issue not directly related to this PR. I will try to fix that one in another PR! :)