search

ls1intum / Apollon_standalone

Standalone version of Apollon Editor
MIT License
11 stars 2 forks source link

enhancement: include new lib/es6 output of apollon. #24

Closed martindevtum closed 2 years ago

martindevtum commented 2 years ago

Motivation and Context

This PR handles integration of changes in https://github.com/ls1intum/Apollon/pull/204 . Apollon now provides output in lib/es5 and lib/es6. We want to also upgrade our typescript to produce es2020 output.

Description

I adjusted two required paths to consume from apollon/lib/es6. I upgraded the root and webapp tsconfig to produce es2020 output

Steps for Testing

These changes should be tested in conjunction with my Apollon PR (https://github.com/ls1intum/Apollon/pull/204).

Steps:

  1. Inside Apollon repository: 1.1. checkout the enhancement/create_additional_es5_output in apollon. 1.2. rm -rf node_modules && yarn install && yarn prepare 1.3. yarn link
  2. Inside Apollon_standalone 2.1. checkout the enhancement/include_es6_apollon branch 2.2. yarn install && yarn link "@ls1intum/apollon" && yarn start

The webapp should be running normally now. When checking the source files inside the browser you can see that the Apollon webapp uses the files from lib/es6. the typescript output of the webapp should be es2020, you can check this by adding an outputDir to the packages/webapp/tsconfig.json and running tsc -p ./packages/webapp/tsconfig.json